Fix stuck progress label during non-advancing reqs2X phases#341
Open
ThisCakeIsALie wants to merge 2 commits into
Open
Fix stuck progress label during non-advancing reqs2X phases#341ThisCakeIsALie wants to merge 2 commits into
ThisCakeIsALie wants to merge 2 commits into
Conversation
The progress notification only updated its label when the numeric progress advanced (increment > 0). Reqs2X emits a progress event at the start of each phase with the new step name but no advance, so the notification stayed frozen on the previous phase's label — e.g. showing "Precomputing context" for the whole "waiting for first model response" window while tests were already being generated. Report on a step-label change too, clamping the bar increment to 0 for label-only updates. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Addresses SonarQube: prefer Math.max(increment, 0) over a ternary. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The progress notification only updated its label when numeric progress advanced (
increment > 0). Reqs2X emits a progress event at the start of each phase with the new step name but no advance, so the notification stayed frozen on the previous phase's label — e.g. showing "Precomputing context" for the whole "waiting for first model response" window while tests were already being generated (pronounced in batched mode, where the first test yields late).Report on a step-label change too, clamping the bar increment to 0 for label-only updates.