Skip to content
This repository was archived by the owner on Oct 10, 2026. It is now read-only.

Document SecureString analyzer exceptions - #13

Merged
cmendesvdl merged 1 commit into
mainfrom
security/securestring-analyzer-review
Oct 10, 2026
Merged

cmendesvdl merged 1 commit into
mainfrom
security/securestring-analyzer-review

Conversation

@cmendesvdl

Copy link
Copy Markdown
Collaborator

Summary

Adds narrowly scoped SuppressMessageAttribute justifications for PSAvoidUsingConvertToSecureStringWithPlainText:

  • Invoke-CMDownloadBIOSPackage.ps1: AdminService password is converted only to build an in-memory PSCredential; it is not persisted or logged.
  • Tests/FirmwareSafety.Tests.ps1: synthetic test-only password fixture.

No runtime behavior changes. Mirrors the fix already merged in vartaxe/DriverAutomationTool#20.

Validation

  • Both files parse cleanly.
  • PSScriptAnalyzer: 0 findings for the targeted rule.
  • Fork regression harness passed.

Annotate the AdminService PSCredential conversion and synthetic test fixture with narrowly scoped justifications.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@cmendesvdl
cmendesvdl merged commit 13f993b into main Oct 10, 2026
1 check passed
@cmendesvdl
cmendesvdl deleted the security/securestring-analyzer-review branch October 10, 2026 08:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants