fix(isISO8601): only accept T or a space as the date-time separator - #2892
Open
yu2971512385-ui wants to merge 1 commit into
Open
yu2971512385-ui wants to merge 1 commit into
yu2971512385-ui wants to merge 1 commit into
Conversation
The default pattern separated the date and time with `[T\s]`, so tab, newline, form feed, vertical tab and a non-breaking space were all accepted as separators. ISO 8601 permits only `T`, and RFC 3339 §5.6 additionally allows a plain space — no specification allows the rest of `\s`. Accepting a newline is particularly undesirable since it lets a two-line input pass a single-value check. Narrow the class to `[T ]`. `strictSeparator: true` (which already uses `[T]`) is unchanged. Fixes validatorjs#2861 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2892 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2599 2599
Branches 658 658
=========================================
Hits 2599 2599 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2861.
The bug
The default pattern separates the date and time with
[T\s]:\smatches tab, newline, form feed, vertical tab and a non-breaking space in addition to a plain space, so all of them are accepted as ISO 8601 separators:ISO 8601 permits only
T; RFC 3339 §5.6 additionally allows a plain space (which is why the class accepts a space). No relevant specification allows the rest of\s. Accepting a newline is particularly undesirable, since it lets a two-line input pass a single-value check.The fix
Narrow the class in the default pattern to
[T ].strictSeparator: truealready uses[T]and is unchanged; the plain-space separator that RFC 3339 allows (e.g.2009-05-19 14:39:22) keeps working.Tests
Added a case asserting
Tand a space are accepted while tab, newline, form feed, vertical tab and a non-breaking space are rejected. Verified it fails on the unpatched source and passes with the fix; fullnpm testis green.Checklist
🤖 Generated with Claude Code