Skip to content

feat: add es-PR mobile phone validation for Puerto Rico - #2826

Open
RodrigoPavezReyes wants to merge 1 commit into
validatorjs:masterfrom
RodrigoPavezReyes:patch-1
Open

feat: add es-PR mobile phone validation for Puerto Rico#2826
RodrigoPavezReyes wants to merge 1 commit into
validatorjs:masterfrom
RodrigoPavezReyes:patch-1

Conversation

@RodrigoPavezReyes

Copy link
Copy Markdown

Add mobile phone validation for Puerto Rico (es-PR).
Puerto Rico uses area codes 787 and 939 with the +1 country code.

References

Checklist

  • PR contains only changes related; no stray files, etc.
  • References provided in PR (where applicable)

Closes #1761

Add mobile phone validation for Puerto Rico (es-PR).
Puerto Rico uses area codes 787 and 939 with the +1 country code.
Closes validatorjs#1761

@tux-tn tux-tn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR @RodrigoPavezReyes

Please review CONTRIBUTING.md before updating this PR.

The contribution guidelines require changes to include appropriate tests and README documentation where applicable. This PR currently modifies only
src/lib/isMobilePhone.js

Please add:

  • es-PR valid and invalid fixtures in test/validators.test.js
  • es-PR to the isMobilePhone locale list in README.md

Also remove the trailing whitespace on src/lib/isMobilePhone.js:88, which currently causes ESLint to fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mobile Phone validations - For The First Time Contributors

2 participants