refactor: migrate Dialog wrapper to slotted content#391
Open
web-padawan wants to merge 1 commit into
Open
Conversation
Render header/footer/children as light-DOM slotted content instead of routing through the web component's renderer/headerRenderer/footerRenderer properties (deprecated in Vaadin 25, removed in Vaadin 26). - header -> <div slot="header-content">, footer -> <div slot="footer">, children -> default slot; wrappers rendered only when content is present so the web component never derives has-header/has-footer from empty slots. - Deprecated renderer/headerRenderer/footerRenderer props and function children still work, rendered into the slotted wrapper with the dialog element passed as `original` (tracked via useMergedRefs so it is never null when the renderer runs). - Drop useSimpleOrChildrenRenderer usage; no portal-into-renderer-root. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Render header/footer/children as light-DOM slotted content instead of deprecated renderer properties.
<div slot="header-content">, footer -><div slot="footer">, children -> default slot;has-header/has-footerincorrectly;renderer/headerRenderer/footerRendererprops and function children still work.Type of change