Repository navigation
Conversation
The declared rust-version of 1.70 has been out of date for a while. Several dependencies already require a newer compiler, so no toolchain older than 1.88 can build the project today: * `sysinfo` 0.38 (every 0.38.x release) declares rust-version 1.88. * `uutests` 0.12 (dev-dependency) declares rust-version 1.88. * `rand` 0.10, `phf` 0.14, `md-5` 0.11 and the locked `clap` 4.6 declare 1.85, and `lsipc`/`lslocks` use edition 2024, which also needs 1.85. `uucore` 0.7 and later also declare rust-version 1.88, so this is a prerequisite for upgrading `uucore` from 0.2.2. The field documents the real minimum and is what the MSRV-aware resolver and clippy's MSRV-dependent lints (e.g. `incompatible_msrv`) use, so it should match what the dependencies need. Note that the checked-in Cargo.lock currently has `uuid` 1.28, which declares rust-version 1.89. A 1.88 toolchain needs `uuid` <= 1.26.1; the MSRV-aware resolver (`CARGO_RESOLVER_INCOMPATIBLE_RUST_VERSIONS=fallback cargo update`) picks that version. CI builds with the latest stable toolchain and has no MSRV job, so no workflow change is needed.
sylvestre
reviewed
Oct 24, 2026
| keywords = ["util-linux", "uutils", "cross-platform", "cli", "utility"] | ||
| categories = ["command-line-utilities"] | ||
| rust-version = "1.70.0" | ||
| rust-version = "1.88.0" |
Contributor
There was a problem hiding this comment.
Cargo.lock still has uuid 1.28, which needs 1.89.
should we downgrade it here too so 1.88 actually builds with the lock?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The declared rust-version of 1.70 has been out of date for a while. Several dependencies already require a newer compiler, so no toolchain older than 1.88 can build the project today:
sysinfo0.38 (every 0.38.x release) declares rust-version 1.88.uutests0.12 (dev-dependency) declares rust-version 1.88.rand0.10,phf0.14,md-50.11 and the lockedclap4.6 declare 1.85, andlsipc/lslocksuse edition 2024, which also needs 1.85.uucore0.7 and later also declare rust-version 1.88, so this is a prerequisite for upgradinguucorefrom 0.2.2.The field documents the real minimum and is what the MSRV-aware resolver and clippy's MSRV-dependent lints (e.g.
incompatible_msrv) use, so it should match what the dependencies need.Note that the checked-in Cargo.lock currently has
uuid1.28, which declares rust-version 1.89. A 1.88 toolchain needsuuid<= 1.26.1; the MSRV-aware resolver(
CARGO_RESOLVER_INCOMPATIBLE_RUST_VERSIONS=fallback cargo update) picks that version. CI builds with the latest stable toolchain and has no MSRV job, so no workflow change is needed.