[jayhemnani9910]

setsid only takes -c, -f and -w. util-linux also has --ctty, --fork and --wait (setsid(1)):

$ setsid --fork --wait /usr/bin/false; echo $?
util-linux 2.41.3: 1
uutils:            error: unexpected argument '--fork' found ... 1

The three arguments now have their long names. New test long_options (fails on main); the setsid tests pass (12) and clippy is clean. --fork --wait, --wait and --fork give the same exit codes as util-linux.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

[sylvestre]

weak test, could you please use terminal_simulation like unprivileged_user_can_take_new_controlling_tty and check that --wait --ctty succeeds?

[jayhemnani9910]

Done in 6a075af: long_options_take_new_controlling_tty runs setsid --wait --ctty under terminal_simulation, as unprivileged_user_can_take_new_controlling_tty does, and checks it succeeds and the controlling terminal changes. It fails on main. I dropped the old --ctty check from long_options.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.