Repository navigation
last: show the first record's time in "begins" when -n, --since or --until skip records - #673
Merged
Conversation
…until skip records
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
Contributor
|
Thanks for your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "begins" line is set only when the loop reaches the oldest record. When
-n,--sinceor--untilskips it,lastprints the file's ctime instead. util-linux 2.41.3 always prints the first record's time:The time now comes from the first record in the file, before any filtering. An empty file still falls back to the ctime.
test_since_only_shows_entries_after_timechecked that "16:24" appears nowhere in the output. That held only because of this bug: the correct "begins" line isSat Mar 8 16:24:36 2025, as util-linux prints it. The test now checks the entry lines only.New test
test_begins_is_the_first_record_when_records_are_skipped(-n 1and--since) fails without the change.cargo testfor the tools that build here (all but lsipc, lslocks and lsns, which need libsmartcols): 233 passed. With TZ=UTC, the "begins" line matches util-linux 2.41.3 for-n 1,--sinceand no options.