Repository navigation
chmod: report umask conflict below the -R operand - #15885
Merged
Merged
Conversation
with a bare mode like -w, only the operand itself was checked for bits the umask kept. Entries found while recursing were changed silently. Chmod also exited with 0. Moved the check into a helper function and call it safe_chmod_file()
eylulseyit
marked this pull request as ready for review
October 26, 2026 20:03
Collaborator
|
Thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a bare mode like -w, only the operand itself was checked for bits the umask kept. Entries found while recursing were changed silently and chmod exited with 0. Moved the check into a helper function and call it from safe_chmod_file() too, so every affected entry is reported like GNU does.
Closes #15774