Skip to content

Don't build std*_was_closed for fuchsia - #15732

Merged
cakebaker merged 1 commit into
uutils:mainfrom
oech3:ebadf-open
Oct 26, 2026
Merged

cakebaker merged 1 commit into
uutils:mainfrom
oech3:ebadf-open

Conversation

@oech3

@oech3 oech3 commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

This causes build failure at some utils.

@oech3 oech3 changed the title Don't build exclude std*_was_closed for fuchsia Don't build std*_was_closed for fuchsia Oct 25, 2026
@xtqqczze

xtqqczze commented Oct 25, 2026 •

Copy link
Copy Markdown
Collaborator

Please revert the changes to src/uucore/src/lib/features/signals.rs. We don't build the signals feature for Fuchsia targets as the platform does not support Unix signals.

@xtqqczze

Copy link
Copy Markdown
Collaborator

Follow-up to #14166.

@xtqqczze

xtqqczze commented Oct 25, 2026 •

Copy link
Copy Markdown
Collaborator

cat now builds successfully on Fuchsia targets with these changes:

RUSTC_BOOTSTRAP=1 cargo clippy -q -Zbuild-std=std \
  -p uu_cat --lib --target x86_64-unknown-fuchsia

@cakebaker
cakebaker merged commit 7ce4d8c into uutils:main Oct 26, 2026
100 checks passed
@cakebaker

Copy link
Copy Markdown
Contributor

Thanks!

@oech3
oech3 deleted the ebadf-open branch October 26, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants