Skip to content

refactor(uucore)!: remove uio_error macro - #15104

Open
xtqqczze wants to merge 1 commit into
uutils:mainfrom
xtqqczze:refactor/uucore-rm-uio-error
Open

xtqqczze wants to merge 1 commit into
uutils:mainfrom
xtqqczze:refactor/uucore-rm-uio-error

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@xtqqczze
xtqqczze force-pushed the refactor/uucore-rm-uio-error branch from 8196a0f to 77131dd Compare October 5, 2026 22:29
@codspeed

codspeed Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

1 warning, 1 note

⚠️ 122 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

ℹ️ 1 benchmark has no flamegraph

The flamegraph wasn't generated: most of the time was spent in runtime internals, which would leave nothing useful to analyze.

See affected benchmarks

✅ 401 untouched benchmarks
⏩ 70 skipped benchmarks1


Comparing xtqqczze:refactor/uucore-rm-uio-error (892bddd) with main (1d6ca65)2

Open in CodSpeed

Footnotes

  1. 70 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (0776385) during the generation of this report, so 1d6ca65 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@xtqqczze
xtqqczze force-pushed the refactor/uucore-rm-uio-error branch from 77131dd to 12b5c32 Compare October 6, 2026 00:58
@xtqqczze
xtqqczze force-pushed the refactor/uucore-rm-uio-error branch 2 times, most recently from 5f0be3b to 8cdb21a Compare October 9, 2026 22:10
@xtqqczze
xtqqczze force-pushed the refactor/uucore-rm-uio-error branch 2 times, most recently from 3cc560b to 2297eac Compare October 22, 2026 02:05
@xtqqczze
xtqqczze requested a review from RenjiSann October 26, 2026 01:39
@xtqqczze
xtqqczze marked this pull request as ready for review October 26, 2026 01:40
cp-error-same-file = { $source } and { $dest } are the same file
cp-error-backing-up-destroy-source = backing up { $dest } might destroy source; { $source } not copied
cp-error-cannot-open-for-reading = cannot open { $source } for reading
cp-error-cannot-open-for-reading = cannot open { $source } for reading: permission denied

@xtqqczze xtqqczze Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gnu prints "Permission denied" with a capital P; this will be fixed by #13680.

@sylvestre
sylvestre force-pushed the refactor/uucore-rm-uio-error branch from 2297eac to 892bddd Compare October 26, 2026 01:53

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant