tsort: include filename in error message - #14253
Open
abhijeetvichare76 wants to merge 1 commit into
Open
Conversation
GNU tsort names the file it could not open; ours dropped it because the File::open error was propagated without context. Use map_err_context, as nl and wc already do.
abhijeetvichare76
force-pushed
the
tsort-error-filename
branch
from
August 29, 2026 23:11
d25d528 to
9acfb40
Compare
abhijeetvichare76
marked this pull request as ready for review
August 29, 2026 23:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GNU
tsortnames the file it could not open, ours did not:The
File::openerror was propagated without context. Fixed withmap_err_context, asnlandwcalready do. Added a regression test.