Skip to content

chgrp: gate by target support - #14242

Open
xtqqczze wants to merge 1 commit into
uutils:mainfrom
xtqqczze:targets-chgrp
Open

chgrp: gate by target support#14242
xtqqczze wants to merge 1 commit into
uutils:mainfrom
xtqqczze:targets-chgrp

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Gate chgrp to Unix targets.

This moves the relevant target-specific handling behind the appropriate platform support checks, avoiding compilation or functionality on targets where it is not available.

Split from #12317.

@github-actions

github-actions Bot commented Aug 29, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/tail-n0f (fails in this run but passes in the 'main' branch)

@xtqqczze
xtqqczze marked this pull request as ready for review August 29, 2026 21:28
@github-actions

github-actions Bot commented Aug 29, 2026

Copy link
Copy Markdown

Binary size comparison:

Individual binary size comparison VS main (threshold: >=5% AND >=4 KB).

Total size of compared binaries: 152.18 MB (+1004 KB, +0.65%)

Significant per-binary changes:
  comm     1.12 MB ->    2.33 MB  (+1.21 MB, +107.29%)

@xtqqczze

This comment was marked as outdated.

@xtqqczze
xtqqczze marked this pull request as draft August 29, 2026 23:06
@codspeed-hq

codspeed-hq Bot commented Aug 29, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 361 untouched benchmarks
⏩ 50 skipped benchmarks1


Comparing xtqqczze:targets-chgrp (0353034) with main (e2f2570)

Open in CodSpeed

Footnotes

  1. 50 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@xtqqczze
xtqqczze marked this pull request as ready for review August 30, 2026 00:13
@xtqqczze

Copy link
Copy Markdown
Contributor Author

@sylvestre ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant