Skip to content

stty: verify tcsetattr applied all requested settings #14196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MadeNavaneeth wants to merge 1 commit into
base: main
Choose a base branch
from
Open

stty: verify tcsetattr applied all requested settings #14196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/uu/stty/src/stty.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,6 +437,20 @@ fn stty(opts: &Options) -> UResult<()> {
}
}
tcsetattr(opts.file.as_fd(), set_arg, &termios)?;

// Verify that tcsetattr actually applied all requested settings.
// POSIX allows tcsetattr to succeed while only partially applying
// changes. GNU stty re-reads and compares; we do the same.
let actual = tcgetattr(opts.file.as_fd()).map_err_context(|| opts.device_name.clone())?;
if actual != termios {
return Err(USimpleError::new(
1,
format!(
"{0}: unable to perform all requested tcsetattr operations",
opts.device_name
),
));
}
} else {
let termios = tcgetattr(opts.file.as_fd()).map_err_context(|| opts.device_name.clone())?;
print_settings(&termios, opts)?;
Expand Down
Loading