base32/base64/basenc: accept a -w value starting with - to match GNU - #14084
Open
AlejandroCoronadoN wants to merge 1 commit into
Open
base32/base64/basenc: accept a -w value starting with - to match GNU#14084AlejandroCoronadoN wants to merge 1 commit into
AlejandroCoronadoN wants to merge 1 commit into
Conversation
Merging this PR will improve performance by 3.7%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | cksum_crc32b |
39.7 ms | 38.1 ms | +4.19% |
| ⚡ | Simulation | cksum_sysv |
68.4 ms | 66.3 ms | +3.22% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing AlejandroCoronadoN:base-wrap-hyphen-value (48e182d) with main (36947fc)
Footnotes
-
50 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
|
GNU testsuite comparison: |
oech3
reviewed
Aug 22, 2026
| .short('w') | ||
| .long(options::WRAP) | ||
| .value_name("COLS") | ||
| // GNU takes the token after -w as the wrap size even when it starts with '-'. |
Contributor
There was a problem hiding this comment.
Suggested change
| // GNU takes the token after -w as the wrap size even when it starts with '-'. |
Comment is unnecessary if you added test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
base64 -w -5(and any-wvalue that starts with-, e.g.-w -d) was rejected by the argument parser withunexpected argument '-5' found, while GNU takes the token after-was the wrap size and reportsinvalid wrap size:Adding
allow_hyphen_values(true)to the-w/--wrapargument lets the value reach the existing wrap-size parser, which already emits the GNU-matching message. Verified against GNU for-w -5,-w -d,-w -x(allinvalid wrap size), with valid values (-w 5,-w0,--wrap=5) and decoding unchanged. The sharedbase_common.rscovers base32, base64 and basenc.