tty: support printing msys2 tty path#12083
Open
ChrisDenton wants to merge 1 commit intouutils:mainfrom
Open
Conversation
ed60a3c to
3ffb925
Compare
oech3
reviewed
Apr 29, 2026
Contributor
|
This PR is useful when tty.exe is built for native Windows target, but working on MSYS2. Right? |
Contributor
Author
|
Yes, that's the idea. Which is one of the reasons rust's standard library supports detecting msys2 terminals even on the native targets. |
oech3
reviewed
Apr 29, 2026
This comment was marked as resolved.
This comment was marked as resolved.
|
GNU testsuite comparison: |
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
Done. Oh I added an ignore to the top of the file. But adding it to the word list does seem better because this is unlikely to be the only place it's used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we know we have a terminal handle then we can try printing its file name. If that fails then fallback to the default.