Skip to content

tee: move aborted to MultiWriter#12078

Merged
cakebaker merged 1 commit intouutils:mainfrom
oech3:tee-aborted
Apr 29, 2026
Merged

tee: move aborted to MultiWriter#12078
cakebaker merged 1 commit intouutils:mainfrom
oech3:tee-aborted

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented Apr 29, 2026

to dedup some code of #11943

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/tail-n0f (passes in this run but fails in the 'main' branch)

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 29, 2026

Merging this PR will improve performance by 4.82%

⚡ 1 improved benchmark
✅ 310 untouched benchmarks
⏩ 46 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation df_deep_directory 368.3 µs 351.4 µs +4.82%

Comparing oech3:tee-aborted (e0a2dc4) with main (5aade31)2

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (dd72eca) during the generation of this report, so 5aade31 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@oech3 oech3 marked this pull request as ready for review April 29, 2026 09:32
@xtqqczze
Copy link
Copy Markdown
Contributor

what does this help deduplicate, exactly?

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Apr 29, 2026

aborted is accessed from its code path. It is difficult to add make helper fn to dedup if it is not part of MultiWriter.

@xtqqczze
Copy link
Copy Markdown
Contributor

perhaps this change should be part of that future refactoring?

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Apr 29, 2026 via email

@xtqqczze
Copy link
Copy Markdown
Contributor

I need this soon. Is there any disadvantage for separating PR.

it was harder to review when the motivation was unclear, but ok

@cakebaker cakebaker merged commit 282bcd8 into uutils:main Apr 29, 2026
169 checks passed
@cakebaker
Copy link
Copy Markdown
Contributor

@oech3 it's also fine to add multiple commits to a single PR if they belong together. Anyway, thanks!

@oech3 oech3 deleted the tee-aborted branch April 29, 2026 13:20
@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Apr 29, 2026

Thankyou! I deduped #11943 (just -10 lines...).

I use different PR to make rebase easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants