df: don't show entries previously considered best#12071
Open
Gelbpunkt wants to merge 1 commit intouutils:mainfrom
Open
df: don't show entries previously considered best#12071Gelbpunkt wants to merge 1 commit intouutils:mainfrom
Gelbpunkt wants to merge 1 commit intouutils:mainfrom
Conversation
We would go over all the mountpoints and only display those considered the "best" for a device. However, if we found a new "best" entry for a device, we would still display the entry previously considered "best". Fix this by removing all previous entries for the same device before adding a new one.
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We would go over all the mountpoints and only display those considered the "best" for a device. However, if we found a new "best" entry for a device, we would still display the entry previously considered "best". Fix this by removing all previous entries for the same device before adding a new one.
Previously with the following mounts:
/var/cache/apkis the first entry that was seen and it was considered best, and it remains the best entry until/etc/apk/keysis encountered, which is considered the new best entry. Currently, this would result in both being printed:After this change, finding a new best would get rid of any entry previously considered best, resulting in
which matches GNU coreutils: