install: keep post-copy finalization bound to created file#12063
Open
parasol-aser wants to merge 3 commits intouutils:mainfrom
Open
install: keep post-copy finalization bound to created file#12063parasol-aser wants to merge 3 commits intouutils:mainfrom
parasol-aser wants to merge 3 commits intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
oech3
reviewed
Apr 28, 2026
| use filetime::set_file_times; | ||
| use filetime::{FileTime, set_file_handle_times}; | ||
| #[cfg(unix)] | ||
| use nix::unistd::{Gid, Uid, dup, fchown}; |
Contributor
There was a problem hiding this comment.
Is it able to use rustix instead?
Author
There was a problem hiding this comment.
Swapped this over to rustix in c62d1d0 and re-ran the two targeted install tests; both pass.
Contributor
|
Please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12062.
This keeps
installbound to the file it actually created instead of reopening the destination by pathname during post-copy finalization.What changed:
O_NOFOLLOW | O_EXCLto fd-based destination creation--strip-program,chmod,chown, and timestamp updates against that file handle--strip-programcaseValidation:
cargo +1.93.0-x86_64-unknown-linux-gnu build -p uu_install --bin installcargo +1.93.0-x86_64-unknown-linux-gnu test --test tests --features 'install chmod' test_install::test_install_and_strip_with_program_hyphen -- --exact --nocapturecargo +1.93.0-x86_64-unknown-linux-gnu test --test tests --features 'install chmod' test_install::test_install_strip_program_symlink_swap_does_not_touch_victim -- --exact --nocapture