Skip to content

parser: read length without parentheses as length($0) #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alonely0 merged 2 commits into from
Oct 25, 2026
Merged

parser: read length without parentheses as length($0) #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ebf74d
parser: read length without parentheses as length($0)
jayhemnani9910 Oct 23, 2026
4c3e241
tests: cover length(/re/) and length $1 with the bare length change
jayhemnani9910 Oct 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lexer/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ pub enum Token<'a> {
#[token("function", accept_expression)]
#[token("func", |lex| parse_non_posix_keyword(lex, Token::Function))]
Function,
#[token("length", accept_expression)]
#[token("length", accept_operator)]
Length,
#[token("substr", accept_expression)]
Substr,
Expand Down
13 changes: 10 additions & 3 deletions parser/src/pratt.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ use lexer::{Span, Token};
use crate::{
ArrayPlace, IdentifierExt, Lexer, Parser, Result,
ast::{
ArrayOperator, Atom, BinaryOperator, BinaryPlaceOperator, BindingPower, Expr, ExprNode,
Getline, Place, Redirection, Ternary, UnaryOperator, UnaryPlaceOperator, Variable,
WriteKind,
ArrayOperator, Atom, BinaryOperator, BinaryPlaceOperator, BindingPower, BuiltinFunction,
Expr, ExprNode, Getline, Place, Redirection, Ternary, UnaryOperator, UnaryPlaceOperator,
Variable, WriteKind,
},
diagnostics::ParsingError,
lex::{SpanExt, TokenExt},
Expand Down Expand Up @@ -358,6 +358,13 @@ impl<'a, 'b> Pratt<'a, 'b> {
lex.span().since(anchor),
))
}
} else if next == Token::Length && !lex.peek_is(&Token::OpenParent) {
// POSIX: `length` without an argument list is `length($0)`.
Ok(Expr::node(
ExprNode::BuiltinCall(BuiltinFunction::Length, Vec::new_in(self.parser.arena)),
self.parser,
lex.span().since(anchor),
))
} else if let Some(builtin) = next.maps_to_builtin() {
self.parser
.parse_function_call::<false>(lex, |args| ExprNode::BuiltinCall(builtin, args))
Expand Down
14 changes: 14 additions & 0 deletions tests/by-util/test_awk.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -982,3 +982,17 @@ fn nr_counts_across_files() {
.succeeds()
.stdout_is("1 1\n2 2\n3 1\n");
}

#[test]
fn length_without_parentheses_is_length_of_record() {
ucmd()
.arg("length > 2 { print length, length / 2 } BEGIN { print length }")

@sylvestre sylvestre Oct 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please also cover length(/b/) and length $1 here?
the lexer change makes sure these keep working

@jayhemnani9910 jayhemnani9910 Oct 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in f78f1fb: { print length(/b/), length $1 } on abc def and xyz gives 1 7abc and 1 3xyz, the same as gawk 5.3.2 (length $1 is length followed by $1, concatenated).

.pipe_in("ab\nabcd\nxyz\n")
.succeeds()
.stdout_only("0\n4 2\n3 1.5\n");
ucmd()
.arg("{ print length(/b/), length $1 }")
.pipe_in("abc def\nxyz\n")
.succeeds()
.stdout_only("1 7abc\n1 3xyz\n");
}
Loading