You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR adds Span::publish() for fire-and-forget event export without storage interaction, and refactors finish() into two private helpers — complete() for timestamp/level computation and exportSpan() for exporter dispatch — keeping the two call paths consistent. The implementation is clean, attribute validation silently skips invalid keys and values (consistent with the "never break the application" philosophy), and the ten new tests cover all specified behaviors.
Confidence Score: 5/5
Safe to merge — no correctness, security, or behavioral regressions found.
No P0 or P1 issues identified. The refactoring correctly preserves existing finish() semantics, publish() is well-scoped and thoroughly tested, and attribute validation is intentionally lenient rather than throwing.
No files require special attention.
Important Files Changed
Filename
Overview
src/Span/Span.php
Adds publish() static method for storage-free immediate export; refactors finish() by extracting complete() and exportSpan() helpers with no behavioral regressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Span::publish()for immediate storage-free publishing to configured exporters.publish()andfinish()so timestamps, level defaults, samplers, and exporter exception handling stay consistent.Testing
composer testcomposer formatcomposer analyze