(feat): map OAS 3.1 annotated enumerations onto StringSchema - #9
Merged
Conversation
Greptile SummaryThe PR maps OpenAPI 3.1 annotated string enumerations onto synthesized
Confidence Score: 5/5The PR appears safe to merge because no blocking failure remains within the eligible follow-up-review scope. No blocking failure remains. Important Files Changed
Reviews (3): Last reviewed commit: "(docs): describe enum names using schema..." | Re-trigger Greptile |
Member
Author
|
@greptile review |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
oneOf/anyOfofconst+title) onto the existingStringSchemafields (enum,enumName,enumKeys,open) so sdk-generator does not need to walk unions.title. Value names are each branch’stitle. Vendor extensions stay opaque and are not used for enum metadata.CompositeSchema. CallstringEnum()for the synthesizedStringSchema.openStringEnumBranch()is the open subset (anyOfwith an unconstrainedtype: string).Changes
CompositeSchemadetects closed and open annotated string enums (nestedoneOfinsideanyOf, or flattened consts plus unconstrained string), synthesizesStringSchema, and throwsInvalidSpecificationwith a JSON Pointer for object/const mixes, numeric consts, and multi-value enum mixed with const.ReaderfillsStringSchemaenum values fromenum/constonly. Type and value names come from titles on annotated enumerations.oneOf/anyOf, missing titles, nested and flattened open enums, rejection cases, and the legacy multi-value openanyOfshape.Test plan
composer testpasses locally — 65 tests, 471 assertionsappwrite/specs(and the spec emitter) to annotated enumerations before bumping sdk-generator to 0.2getEnumSchematostringEnum()and update fixtures to the official shape