Add explicit schema reference resolution - #10
Merged
Conversation
Greptile SummaryAdds an explicit schema-reference resolver to the immutable specification model.
Confidence Score: 5/5The PR appears safe to merge; no new actionable issues or outstanding blocking findings remain. The locality check now occurs before percent-decoding, so encoded external references remain unresolved while encoded local names resolve correctly. The earlier Swagger coverage thread was manually resolved without explanation. Important Files Changed
Reviews (5): Last reviewed commit: "address greptile review feedback (greplo..." | Re-trigger Greptile |
Member
Author
|
@greptile review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
Specification::resolveSchema()for consumers that need the concrete type behind a local component schema reference.The resolver:
#/components/schemas/...references#/definitions/...referencesReferenceSchemaobjects by defaultThis lets appwrite/sdk-generator infer transport behavior for referenced binary schemas without maintaining its own reference traversal.
Related to appwrite/sdk-generator#1871 and CLO-4377.
Test plan
composer check