refactor: drop compound databaseId:tableId resourceId

[abnegate]

Summary

• CSV/JSON sources and destinations now take string \$databaseId, string \$tableId directly. The colon-splitting on \$resourceId is gone.
• Target::run / Source::run / Destination::run / Transfer::run gain a new optional \$rootResourceChildId parameter. For database roots, this scopes the transfer to a specific table within the root database. \$rootResourceId keeps its existing semantics (always matches \$rootResourceType).
• Sources/Appwrite no longer inspects `rootResourceId` for ":" or splits it; uses `$this->rootResourceChildId` for per-table filtering.

Test plan

• composer lint passes locally
• composer check (PHPStan level 3) passes locally
• CSV/JSON unit tests updated to pass separate IDs

Linked

• Consumer: refactor(migrations): split composite resourceId into parent/leaf appwrite/appwrite#12193

🤖 Generated with Claude Code

[greptile-apps]

Greptile Summary

This PR replaces the compound databaseId:tableId $resourceId string with separate $databaseId / $tableId parameters across CSV/JSON sources and destinations, and introduces an explicit $rootResourceChildId parameter on the run() chain to scope per-table transfers without colon-splitting.

• The abstract Target::run() signature is missing $rootResourceType — its 4th positional parameter is $rootResourceChildId, but both Source::run and Destination::run insert $rootResourceType as the 4th param and push $rootResourceChildId to 5th. Any caller typed against Target that passes four positional args will silently bind its $rootResourceChildId value into $rootResourceType, leaving $rootResourceChildId as ''.

Confidence Score: 3/5

Not safe to merge until the abstract Target::run signature is fixed to include $rootResourceType in the correct position.

One P1 defect: the abstract method in Target declares $rootResourceChildId as the 4th param while both concrete implementations have $rootResourceType there, making per-table scoping silently broken for any caller using the abstract interface. All other changes are clean.

src/Migration/Target.php — abstract run signature must add $rootResourceType in the correct position.

Important Files Changed

Filename	Overview
src/Migration/Target.php	Abstract run signature is missing $rootResourceType — 4th positional param conflicts with concrete implementations, causing silent $rootResourceChildId misrouting.
src/Migration/Source.php	Adds $rootResourceChildId parameter and stores it; correctly assigns all three root-resource fields.
src/Migration/Destination.php	Passes $rootResourceChildId through to the source's run; signature and delegation are correct.
src/Migration/Transfer.php	Adds $rootResourceChildId to run, null-coalesces it to '', and passes it to $this->destination->run; logic is correct.
src/Migration/Sources/Appwrite.php	Replaces colon-splitting on $rootResourceId with direct use of $this->rootResourceChildId; filtering logic is cleaner and correct.
src/Migration/Sources/CSV.php	Splits $resourceId into $databaseId + $tableId constructor params; removes the explode call and uses the fields directly.
src/Migration/Sources/JSON.php	Same split-param refactor as CSV source; exportRows now uses fields directly instead of explode.
src/Migration/Destinations/CSV.php	Constructor split into $databaseId + $tableId; error messages updated accordingly.
src/Migration/Destinations/JSON.php	Same constructor split as CSV destination; straightforward and correct.
tests/Migration/Unit/General/CSVTest.php	All test call-sites updated to pass separate databaseId / tableId args.
tests/Migration/Unit/General/JSONTest.php	Same test call-site updates as CSVTest; both destination instantiations corrected.

_{Reviews (1): Last reviewed commit: "refactor: drop compound `databaseId:coll..." | Re-trigger Greptile}

[greptile-apps]

Abstract run signature is missing $rootResourceType

The abstract declares the 4th positional parameter as $rootResourceChildId, but both concrete overrides (Source::run and Destination::run) insert $rootResourceType as the 4th parameter and push $rootResourceChildId to 5th. Any caller typed as Target that passes 4 positional args will silently route their $rootResourceChildId value into $rootResourceType, leaving $rootResourceChildId as '' and making table-scoped transfers silently no-ops.

Suggested change

	abstract public function run(array $resources, callable $callback, string $rootResourceId = '', string $rootResourceChildId = ''): void;
	abstract public function run(array $resources, callable $callback, string $rootResourceId = '', string $rootResourceType = '', string $rootResourceChildId = ''): void;