Add automatic saliency cropping - #46
Closed
TorstenDittmann wants to merge 8 commits into
Closed
Conversation
Greptile SummaryThis PR adds
Confidence Score: 4/5
Important Files Changed
Reviews (6): Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." | Re-trigger Greptile |
# Conflicts: # .gitignore # Dockerfile-php-8.1 # Dockerfile-php-8.2 # Dockerfile-php-8.3 # composer.json # composer.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Image::GRAVITY_AUTOfor saliency-aware croppingankane/onnxruntimeImage::detect()so model inference can run in a dedicated workercrop()to consume a persisted detection result without loading ONNXUsage
The detection result contains
width,height, and a normalized two-dimensionalmask.Model and runtime
8d10d2f3bb75ae3b6d527c77944fc5e7dcd94b29809d47a739a7a728a912b491resources/models/NOTICE.mdOnnxRuntime\Vendor::checkto root Composer post-install and post-update scriptsPerformance
Measured on an Apple M3 Pro with a 1280x837 JPEG cropped to 180x320:
Native ONNX Runtime and Imagick allocations are not fully represented by PHP's memory counter. Automatic detection is best suited to an asynchronous, controlled-concurrency worker.
Testing
vendor/bin/pint --test