Skip to content

Update Domains dependency to 4.0 - #24

Merged
ChiragAgg5k merged 1 commit into
mainfrom
chore/domains-4
Sep 4, 2026
Merged

Update Domains dependency to 4.0#24
ChiragAgg5k merged 1 commit into
mainfrom
chore/domains-4

Conversation

@ChiragAgg5k

Copy link
Copy Markdown
Member

Summary

  • update utopia-php/domains to ^4.0.0
  • refresh the locked Domains version to 4.0.0

Validation

  • composer test
  • composer lint
  • composer check

@greptile-apps

greptile-apps Bot commented Sep 4, 2026

Copy link
Copy Markdown

Greptile Summary

This PR upgrades utopia-php/domains from 3.0.0 to 4.0.0 and refreshes the Composer lock metadata.

  • Keeps the dependency compatible with the repository’s PHP 8.5 and Validators 0.6 constraints.
  • Introduces mandatory curl, mbstring, and SimpleXML platform requirements that are not currently documented or validated by CI.

Confidence Score: 4/5

The dependency upgrade appears safe to merge, with a non-blocking documentation and CI coverage gap around its new PHP extension requirements.

No API or dependency-resolution failure was established, but the upgrade introduces mandatory extensions that the documented system requirements omit and current CI installations explicitly bypass.

Files Needing Attention: composer.lock

Important Files Changed

Filename Overview
composer.json Updates the Domains dependency constraint from ^3.0 to ^4.0.0; its declared constraints remain mutually compatible.
composer.lock Locks Domains 4.0.0 and records three new required PHP extensions that are not reflected in project documentation or platform validation.

Fix all with Greploop Fix All in Claude Code Fix All in Codex

Prompt To Fix All With AI
### Issue 1
composer.lock:2009-2011
**Undocumented Extension Requirements**

Domains 4.0 now requires curl, mbstring, and SimpleXML, but the README still lists PHP 8.5 as the only system requirement, and CI installs dependencies with `--ignore-platform-reqs`. If a consumer uses a minimal PHP installation without one of these extensions, installation will fail without the project’s validation catching it. Please document the new requirements and validate at least one install without bypassing platform checks.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (1): Last reviewed commit: "Update Domains dependency to 4.0" | Re-trigger Greptile

Comment thread composer.lock
Comment on lines +2009 to +2011
"ext-curl": "*",
"ext-mbstring": "*",
"ext-simplexml": "*",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Undocumented Extension Requirements

Domains 4.0 now requires curl, mbstring, and SimpleXML, but the README still lists PHP 8.5 as the only system requirement, and CI installs dependencies with --ignore-platform-reqs. If a consumer uses a minimal PHP installation without one of these extensions, installation will fail without the project’s validation catching it. Please document the new requirements and validate at least one install without bypassing platform checks.

Prompt To Fix With AI
This is a comment left during a code review.
Path: composer.lock
Line: 2009-2011

Comment:
**Undocumented Extension Requirements**

Domains 4.0 now requires curl, mbstring, and SimpleXML, but the README still lists PHP 8.5 as the only system requirement, and CI installs dependencies with `--ignore-platform-reqs`. If a consumer uses a minimal PHP installation without one of these extensions, installation will fail without the project’s validation catching it. Please document the new requirements and validate at least one install without bypassing platform checks.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Fix in Claude Code Fix in Codex

@ChiragAgg5k
ChiragAgg5k merged commit 962d892 into main Sep 4, 2026
5 checks passed
@ChiragAgg5k
ChiragAgg5k deleted the chore/domains-4 branch September 4, 2026 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants