Update Domains dependency to 4.0 - #24
Conversation
Greptile SummaryThis PR upgrades
Confidence Score: 4/5The dependency upgrade appears safe to merge, with a non-blocking documentation and CI coverage gap around its new PHP extension requirements. No API or dependency-resolution failure was established, but the upgrade introduces mandatory extensions that the documented system requirements omit and current CI installations explicitly bypass. Files Needing Attention: composer.lock Important Files Changed
Prompt To Fix All With AI### Issue 1
composer.lock:2009-2011
**Undocumented Extension Requirements**
Domains 4.0 now requires curl, mbstring, and SimpleXML, but the README still lists PHP 8.5 as the only system requirement, and CI installs dependencies with `--ignore-platform-reqs`. If a consumer uses a minimal PHP installation without one of these extensions, installation will fail without the project’s validation catching it. Please document the new requirements and validate at least one install without bypassing platform checks.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "Update Domains dependency to 4.0" | Re-trigger Greptile |
| "ext-curl": "*", | ||
| "ext-mbstring": "*", | ||
| "ext-simplexml": "*", |
There was a problem hiding this comment.
Undocumented Extension Requirements
Domains 4.0 now requires curl, mbstring, and SimpleXML, but the README still lists PHP 8.5 as the only system requirement, and CI installs dependencies with --ignore-platform-reqs. If a consumer uses a minimal PHP installation without one of these extensions, installation will fail without the project’s validation catching it. Please document the new requirements and validate at least one install without bypassing platform checks.
Prompt To Fix With AI
This is a comment left during a code review.
Path: composer.lock
Line: 2009-2011
Comment:
**Undocumented Extension Requirements**
Domains 4.0 now requires curl, mbstring, and SimpleXML, but the README still lists PHP 8.5 as the only system requirement, and CI installs dependencies with `--ignore-platform-reqs`. If a consumer uses a minimal PHP installation without one of these extensions, installation will fail without the project’s validation catching it. Please document the new requirements and validate at least one install without bypassing platform checks.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Summary
utopia-php/domainsto^4.0.04.0.0Validation
composer testcomposer lintcomposer check