skipFilters

[fogelito]

Summary by CodeRabbit

• Refactor
  • Improved internal filter handling mechanism with enhanced type declarations and documentation.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Warning

Rate limit exceeded

@abnegate has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 45 minutes and 12 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c458b369-5054-4a1e-bf74-acafe3608f6d

📥 Commits

Reviewing files that changed from the base of the PR and between c162434 and 87038de.

📒 Files selected for processing (1)

• src/Database/Database.php

📝 Walkthrough

Walkthrough

The $disabledFilters property type is changed from nullable to non-nullable array, and the decodeAttribute method is refactored to compute a skip flag and pass it to filter decoders instead of using early-return checks for filter application logic.

Changes

Cohort / File(s)	Summary
Filter decode refactoring src/Database/Database.php	Type declaration updated: $disabledFilters changed from protected ?array to protected array. Docblock updated from @var array<string, bool>|null to @var array<string, bool>. Method decodeAttribute refactored to compute a skip flag instead of early-returning; decode filter calls now receive the skip parameter for conditional filter bypass.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• Feat/skipfilters optional list #657: Modifies Database::$disabledFilters and the decodeAttribute filter-bypass logic with a per-filter skip list mechanism.
• 0.71.x #662: Updates filter-skipping logic in Database.php involving the disabledFilters property and decodeAttribute method.

Poem

🐰 A filter once fought with its flags,
But now it computes without lags,
No early returns to delay the show,
Just skip signals stealing the flow,
The database hops with refined flair! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'skipFilters' is vague and generic, using a camelCase identifier that doesn't clearly describe the actual changes made.	Consider using a more descriptive title that explains what the change accomplishes, such as 'Refactor filter disabling mechanism to use skip parameter' or 'Change disabledFilters type and implement skip flag logic'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch skip-filters

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Review rate limit: 0/1 reviews remaining, refill in 45 minutes and 12 seconds.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@src/Database/Database.php`:
- Around line 8464-8477: Move the $skip evaluation (the line setting $skip =
$this->filter === false || isset($this->disabledFilters[$filter])) to occur
before the NotFoundException check in decodeAttribute, then call the decoder as
you already do; update every built-in filter decoder closure (json, datetime,
point, linestring, polygon, vector, object) to accept the extra parameter
signature (mixed $value, Document $document, Database $database, bool $skip =
false) and return early with if ($skip) return $value; so they won’t error on
the named parameter skip and will short-circuit when filtering is disabled.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 783193d and c162434.

📒 Files selected for processing (1)

• src/Database/Database.php

🧰 Additional context used

🪛 PHPMD (2.15.0)

src/Database/Database.php

8475-8475: Avoid unused local variables such as '$filters'. (undefined)

(UnusedLocalVariable)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Setup & Build Docker Image

🔇 Additional comments (1)

src/Database/Database.php (1)

395-399: No breaking changes from $disabledFilters becoming non-nullable.

The repository contains no code that assigns null to disabledFilters, and all usage patterns are compatible with a non-nullable array type. The property is always initialized as [] and only ever assigned array values (either empty or populated with filter names). The existing backup/restore pattern in the codebase works correctly with this non-nullable type.

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

[greptile-apps]

Greptile Summary

This PR refactors decodeAttribute to compute a $skip boolean and pass it as a fourth argument to each filter's decode callback, rather than returning early before calling the callback. It also removes the nullable type from $disabledFilters.

• Behavioral regression: all built-in filters (json, datetime, point, linestring, polygon, vector, object) have fixed-arity callbacks that ignore the new $skip argument. When skipFilters or disableFilters is in effect, the decode callbacks now still execute, silently undoing the skip semantics that callers depend on.

Confidence Score: 2/5

Not safe to merge — existing skip/disable-filter semantics are broken for all built-in filters.

A P1 regression breaks the public skipFilters / disableFilters contract: decode callbacks now always run regardless of the skip flag, because none of the built-in implementations accept or check the new fourth parameter.

src/Database/Database.php — specifically the built-in filter decode closures registered in the constructor (lines ~479–676) and decodeAttribute (line ~8464).

Important Files Changed

Filename	Overview
src/Database/Database.php	Refactors skip-filter logic in decodeAttribute to pass a $skip flag into filter callbacks, but built-in filter implementations don't accept/check this flag, breaking the existing skip behaviour.

_{Reviews (1): Last reviewed commit: "AddSkip" | Re-trigger Greptile}

[greptile-apps]

Skip logic no longer applied for built-in filters

The $skip flag is now delegated to each filter's decode callback, but none of the built-in filter implementations (json, datetime, point, linestring, polygon, vector, object) accept or inspect this fourth parameter — PHP silently ignores the extra argument. As a result, calling skipFilters(['datetime']) (or disableFilters()) no longer prevents the decode callback from running; the value is still decoded. The previous code returned early before calling the callback at all when $skip was true.

External instance filters registered by callers are affected the same way — they receive an undocumented fourth argument they almost certainly don't handle.