Conversation
Exit() wraps the caller's error in an exitError, and since urfave#1545 that wrapper had an Unwrap method so errors.Is and errors.As could see the original error through the ExitCoder. The method was dropped in 05071ea ("Add error tests") with no mention in the commit, so on v3 errors.Is(cli.Exit(ErrNotFound, 2), ErrNotFound) is false where it was true on v2 and on earlier v3. Add the method back and cover it with a test.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Exit()wraps the caller's error in an unexportedexitError. Since #1545 (issue #1090) that wrapper had anUnwrap()method soerrors.Is/errors.Ascould reach the original error through theExitCoder. The method was dropped in 05071ea ("Add error tests") without being mentioned in the commit, so on v3 today:origin/v2-maintstill has the method.errors.go: addfunc (ee *exitError) Unwrap() errorback.errors_test.go:TestExit_Unwrapcheckserrors.Is,errors.Unwrap,errors.AstoExitCoder, and the non-error message form. It fails onmainand passes with this change.No exported API changes (
exitErroris unexported), sogodoc-current.txtis unaffected.Release Notes