Conversation
meatballhat
added
kind/feature
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leaving this PR as draft for the moment as I presume there will be nuances once I start using it in my own project.
What type of PR is this?
What this PR does / why we need it:
This PR delegates to the completion flag strategy when the command has a
ShellCompletefunction. This hybrid strategy builds on the assumption that it is cheaper (better ux) to use fish built-in completion when possible and only invoke the binary with completion flag when necessary.Special notes for your reviewer:
This PR removes the blanket application of the default shell completion and instead invokes it
command.ShellComplete == nil. I don't think this is an issue, but it does change the contract slightly.Release Notes