Free leaked _get_dims allocation in dot/diag/cumsum wrappers#24
Merged
Conversation
_get_dims malloc's a c3_d* and returns it. Three call sites used _get_dims(shape)[0] and discarded the pointer, leaking a buffer (proportional to array rank) on every call to the affected wrappers. The other two call sites already capture and free the pointer. Capture the pointer, read [0], and free it at all three sites in each of the three jet files. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_get_dimsu3a_mallocs ac3_d*and returns it. Three call sites in each jet file used_get_dims(shape)[0]and discarded the returned pointer, leaking a buffer (sized to the array's rank) on every call to the affected wrappers (dot/trace, and thecumsum/diag-family wrappers). The two other call sites already capture and free the pointer.Fix
At each leaking site, capture the pointer, read
[0], thenu3a_freeit — across all three jet files:lagoon/vere/noun/jets/i/lagoon.clagoon/vere64/noun/jets/lagoon.cmaroon/vere/noun/jets/i/lagoon.cPure leak fix; no behavioral change.
🤖 Generated with Claude Code