Refactor rotmg to remove goto/labels#22
Merged
Merged
Conversation
The rotmg routines used `goto store` to jump out of the two singular cases (u <= 0 and q2 < 0) to the final store block, skipping the rescaling loops. Replace each with a plain if/else: the non-singular work moves into the else branch, and the rescaling loops that follow are already no-ops when a singular case has zeroed d1 and d2, so no jump is needed. Drops both gotos and the `store:` label from srotmg/drotmg/hrotmg. Behavior is unchanged. Added test_srotmg_singular (q2 < 0 -> all zeros, flag = -1) to cover the refactored path that the goto previously guarded. 181/181 tests pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rotmgusedgoto storeto jump out of the two singular cases (u <= 0andq2 < 0) to the final store block, skipping the rescaling loops.Replaced each with a plain
if/else: the non-singular work moves into theelse, and the rescaling loops that follow are already no-ops once a singular case has zeroedd1/d2— so no jump is needed. Drops both gotos and thestore:label fromsrotmg/drotmg/hrotmg.Behavior unchanged. Added
test_srotmg_singular(q2 < 0 → all zeros, flag = -1) to cover the refactored path the goto previously guarded. 181/181.🤖 Generated with Claude Code