Fix transposed-matrix comments in gemv tests (closes #5)#18
Merged
Conversation
The 0_row/0_col gemv tests commented the matrix as its transpose ([[1,3],[2,4]] for a matrix that is logically [[1,2],[3,4]]). The code was correct; only the comments were wrong. Found and fixed the same mistake in test_dgemv.c and test_hgemv.c while here. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
0_row/0_colgemv tests commented the matrix as its transpose —[[1,3],[2,4]]for a matrix that is logically[[1,2],[3,4]]. The code was correct; only the comments were wrong. Fixed intest_sgemv.c(the issue), plus the same mistake found intest_dgemv.candtest_hgemv.c.Closes #5.
🤖 Generated with Claude Code