Coverage: gemv/gemm transpose paths and leading-dimension padding (C4/C5)#16
Merged
Merged
Conversation
Two whole behavior classes were untested: C4 transpose paths -- only 'N','N' and 'T','T' gemm were exercised, and every gemv test used Trans='N'. Add: - test_sgemv_trans: y = A^T x (the gemv transpose branch) - test_sgemm_transA / _transB: the mixed 'T','N' and 'N','T' gemm combos C5 leading-dimension padding -- only s/d gemm had an ldb!=ldc test. Add: - test_sgemv_padlda: gemv with lda > N (a pad column to skip) - test_hgemm_ldb / test_qgemm_ldb: ldb!=ldc for the half and quad gemm All pass -- the transpose and padding code is correct. 157/157. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
sigilante
force-pushed
the
fix/coverage-transpose-padding
branch
from
e210547 to
3ef94d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two untested behavior classes, now covered. Test-only; everything passes (the code was already correct).
C4 — transpose paths. Only
'N','N'and'T','T'gemm were exercised, and every gemv test usedTrans='N':test_sgemv_trans—y = Aᵀx(the gemv transpose branch)test_sgemm_transA/test_sgemm_transB— the mixed'T','N'and'N','T'gemm combosC5 — leading-dimension padding. Only
s/dgemm had anldb≠ldctest:test_sgemv_padlda— gemv withlda > N(a pad column to skip)test_hgemm_ldb/test_qgemm_ldb—ldb≠ldcfor half and quad gemm157/157.
🤖 Generated with Claude Code