Open
Conversation
elijahr
reviewed
Dec 14, 2021
Contributor
elijahr
left a comment
elijahr
left a comment
There was a problem hiding this comment.
I'm not a maintainer but have contributed a bunch here. Just some suggestions for consistency with the surrounding code.
Owner
|
Thanks @danhunsaker, sorry for the late response but I'm a bit low on time lately. |
Author
|
No rush. The folks over at the archarm repo still haven't responded, so you're doing better than they are. 😁 |
Contributor
|
@uraimo just a heads up, I'm attending to some personal matters and likely won't have time to review PRs here for at least a month. |
Owner
|
@elijahr sure don't worry, everything else comes first. |
|
hi there! any chance we could get this to work? |
martin-g
approved these changes
Oct 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does a couple of things. Primarily, it passes the target architecture to the various Docker commands so that it will stop complaining about not being told in advance. (resolves #21). Secondarily, it groups output lines for easier debugging and suchforth (resolves #62).
As an added bonus, it switches to a fork of archarm with more recent images, which solves the issue seen in testing and downstream use cases where a full system upgrade refuses to complete due to insufficient storage space (resolves #48). This part is expected to be reverted once the upstream merges agners/archlinuxarm-docker#8 and their own builds resume, but who knows how long that might take. The expected reversion is why it's in its own commit, here.