Skip to content

Replace curp lib with curp-validation#287

Merged
franciscocardoso merged 1 commit into
masterfrom
support/replace-curp-lib-with-curp-validation
May 29, 2026
Merged

Replace curp lib with curp-validation#287
franciscocardoso merged 1 commit into
masterfrom
support/replace-curp-lib-with-curp-validation

Conversation

@Prado
Copy link
Copy Markdown
Contributor

@Prado Prado commented May 29, 2026

Replace curp lib with curp-validation

@Prado Prado self-assigned this May 29, 2026
Copilot AI review requested due to automatic review settings May 29, 2026 13:37
@Prado Prado requested review from a team as code owners May 29, 2026 13:37
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Swaps the optional peer dependency used by CurpNumberAssert from the curp package to @randyd45/curp-validation, updating the assert implementation, types, README, and lockfile to match. The validation call changes from curp.validar(value) to new CURP(value).isFormatValid().

Changes:

  • Replace curp with @randyd45/curp-validation in package.json (dev / peer / optional peer / meta) and yarn.lock.
  • Update src/asserts/curp-number-assert.js to import CURP and use new CURP(value).isFormatValid(), and update the "not installed" error string accordingly.
  • Update the TypeScript declaration @requires tag and the README dependency table/link to reference the new package.

Reviewed changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
package.json Replaces curp with @randyd45/curp-validation across devDependencies, peerDependencies, peerDependenciesMeta and optionalPeerDependencies (pinned to 1.0.4).
yarn.lock Removes the curp@^1.3.1 entry and adds the resolved @randyd45/curp-validation@1.0.4 entry.
src/asserts/curp-number-assert.js Switches to the new package's CURP class API and updates the missing-dependency error message.
src/types/index.d.ts Updates the @requires JSDoc tag for curpNumber() to reference the new package name.
README.md Updates the asserts table row and the markdown link reference for the CURP dependency.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread package.json Outdated
Comment thread package.json Outdated
Comment thread package.json Outdated
@Prado Prado force-pushed the support/replace-curp-lib-with-curp-validation branch from 6e3bd59 to f4bae8b Compare May 29, 2026 13:45
@franciscocardoso franciscocardoso merged commit 10ac352 into master May 29, 2026
8 checks passed
@franciscocardoso franciscocardoso deleted the support/replace-curp-lib-with-curp-validation branch May 29, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants