Skip to content

Stats banner: Improve responsiveness - #706

Merged
aprentout merged 2 commits into
masterfrom
ap/pyx-486-v2
Sep 15, 2026
Merged

aprentout merged 2 commits into
masterfrom
ap/pyx-486-v2

Conversation

@aprentout

Copy link
Copy Markdown
Contributor

What does this PR do?

Related to: #

What are the observable changes?

Before

Enregistrement.de.l.ecran.2026-09-15.a.15.03.57.mov

After

Enregistrement.de.l.ecran.2026-09-15.a.15.02.54.mov

Good PR checklist

  • Title makes sense
  • Is against the correct branch
  • Only addresses one issue
  • Properly assigned
  • Added/updated tests
  • Added/updated documentation with Figma design link. Don't forget to replace "design" by "file" in the URL. For example https://www.figma.com/file/example
  • Migrated touched components to Glimmer Components
  • Properly labeled

@linear-code

linear-code Bot commented Sep 15, 2026

Copy link
Copy Markdown

PYX-486

@JulienVannier66 JulienVannier66 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

Comment thread tests/dummy/app/templates/data.hbs Outdated
@badge={{hash icon="fa-star" skin="primary"}}
@titleConfig={{hash text="Commissions"}}
@statValue={{hash label="$5,920" suffix="to authorize"}}
@statValue={{hash label="$5,92012345678901234567890" suffix="to authorize"}}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@statValue={{hash label="$5,92012345678901234567890" suffix="to authorize"}}
@statValue={{hash label="$5,920,123,456,789,012,345,678.90" suffix="to authorize"}}

Nit: For more accurate example

@aprentout
aprentout merged commit a305f59 into master Sep 15, 2026
3 checks passed
@aprentout
aprentout deleted the ap/pyx-486-v2 branch September 15, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants