Uploader: Handle async validation - #705
Merged
Merged
Conversation
Miexil
reviewed
Sep 16, 2026
|
|
||
| export default class BaseUploader extends Service implements UploaderInterface { | ||
| validate(request: UploadRequest, rules: FileValidator[]): ValidationResponse { | ||
| validate(request: UploadRequest, rules: FileValidator[]): Promise<ValidationResponse> { |
Member
There was a problem hiding this comment.
I'm unsure where we currently have uses of this but it's going to be worth checking that it does not create issues ; even just typing related.
I at least see one usage in ember-identity here
Contributor
Author
There was a problem hiding this comment.
This is the only place baseUploader.validate is used, that's why there is a PR open for this 🙏
upfluence-bot
added
reviewed/needs-work
and removed
reviewed/needs-review
reviewed/needs-work
labels
olxmpe
approved these changes
Sep 17, 2026
JulienVannier66
approved these changes
Sep 17, 2026
Miexil
approved these changes
Sep 17, 2026
aprentout
changed the base branch from
master
to
feature/create-payment-without-campaign
September 18, 2026 07:14
aprentout
merged commit Sep 18, 2026
71e65f1
into
feature/create-payment-without-campaign
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Related to: #PYX-452
What are the observable changes?
Good PR checklist