Added DCN on hypertable v2 manage fields button - #280
Merged
Merged
Conversation
nathalieArnoux
marked this pull request as ready for review
September 7, 2026 13:26
nathalieArnoux
requested review from
aprentout and
edouardmisset
and removed request for
a team
September 7, 2026 13:26
| buildMethod: (key: string, extra: { [key: string]: string }) => ColumnDefinition | Column | ||
| ): (ColumnDefinition | Column)[] { | ||
| return columnOptions.reduce((columns, column) => [...columns, ...[buildMethod(column.key, column.extra)]], []); | ||
| return columnOptions.map((column) => buildMethod(column.key, column.extra)); |
Contributor
Author
There was a problem hiding this comment.
Oh yeah forgot to explain, this is a fix for a TS error that I noticed here 👍
edouardmisset
approved these changes
Sep 7, 2026
upfluence-bot
added
reviewed/ready-to-merge
reviewed/needs-work
and removed
reviewed/needs-work
reviewed/ready-to-merge
labels
Miexil
approved these changes
Sep 7, 2026
OwenCoogan
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Related to : #dra-5638
What are the observable changes?
Adds DCN to
Manage Fieldsbutton in Hypertable V2.🧑💻 Developer Heads Up
⚡ Since we are using Ember Octane now:
Useful Resource : Ember Octane vs Classic Cheat Sheet
Good PR checklist
Additional Notes