Repository navigation
Clean up compiler warnings in test targets - #1378
Merged
Merged
Conversation
Fixes #1373. Resolves the 8 categories of compiler warnings flagged in UntoldEngineTests and UntoldEngineRenderTests: #file/#filePath mismatches, unused/never-mutated locals, two unreachable dead-code branches, a redundant Equatable conformance, main-actor isolation on tearDown overrides, Sendable closure captures, a useless nil-coalescing, and deprecated Material init usage. Verified a clean swift build --build-tests produces zero warnings, and both UntoldEngineTests (1727 tests) and make testrenderer (1328 tests) pass with no regressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FrameMetricsCollectoras@unchecked Sendable(it's already lock-protected) and adding@preconcurrency import Metalin a test file.Test plan
swift build --build-tests(clean, all sources + tests touched) produces zero warnings and zero errorsswift test --filter UntoldEngineTests— 1727 tests, 0 failuresmake testrenderer— 1328 tests, exit code 0, no regressions