Repository navigation
[Docs] The glass reference scene: scripts to generate, render and cook the six-pane scene of #1308 - #1374
Open
miogds wants to merge 1 commit into
Open
[Docs] The glass reference scene: scripts to generate, render and cook the six-pane scene of #1308#1374miogds wants to merge 1 commit into
miogds wants to merge 1 commit into
Conversation
…k the six-pane scene of untoldengine#1308 The scene behind the comparison image of untoldengine#1308, as scripts under scripts/tests/blender/scenes/glass_panes/: make_scene.py builds the .blend (six kinds of glass in front of a striped wall, a solid behind each, the stripes texture packed, the camera of the reference view), render_reference.py renders the Blender reference with Cycles under one of the engine's HDR environments and writes the camera in engine coordinates, and a README gives the three steps and what to expect. The script tests' README lists it and the glass section of the materials docs points to it.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scene behind the six-pane comparison image of #1308, as scripts in the repository, so that a golden image of glass can be made from it and the scene changed when needed.
The image of #1308 that was made from it, for reference (Blender, the engine before, the engine after):
What is added
scripts/tests/blender/scenes/glass_panes/:make_scene.pybuilds the.blend: six panes (clear window, solar control, channel glass, a car window, a red lens, black tempered) with the Principled values of the kinds of glass seen in architectural and vehicle models, a sphere or cube behind each, a striped wall from a generated texture packed into the file, a grey floor, and the camera of the reference view.render_reference.pyrenders the Blender reference of that view with Cycles under one of the engine's HDR environments (teatro_massimo_2k.hdrby default, rotated 90° about Z so the panorama's centre is where the engine puts it), and writes the camera in engine coordinates (view.json) through the exporter's own conversion.README.mdwith what is in the scene, the three steps (generate, render, cook withuntoldengine export --convert-orientation), how to place the engine's camera, and what to expect: the black pane cooks as a solid surface, and the channel glass pane differs from Blender on purpose (the engine does not blur what is behind rough glass).scripts/tests/README.mdgets a "Reference scenes" section, and the glass section ofdocs/API/UsingMaterials.mda pointer to the scene.Verified
The three steps run from the repository on Blender 5.2: the scene is saved with the stripes packed, the reference renders (a quick 4-sample pass for the check),
view.jsonis written, andscripts/export-untold --convert-orientationcooks the file into a pack whose log reports the black pane as solid and the channel glass as frosted, as in #1308.