Conversation
The repo had no CI, so a change that breaks users' projects could merge and only be caught later, when the website bumps its submodule pointer. This runs the existing `test` script: tsc with the Vite template's unused-code checks, eslint with the rules create-next-app enables, and prettier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This repo has no CI. A change that breaks users' projects can merge here, and it's only caught later when the website bumps its submodule pointer. By then it's already on
main.What
.github/workflows/ci.ymlruns the existingtestscript (bun run test) on every PR and on pushes tomain:tsc, including the Vite template'snoUnusedLocalsandnoUnusedParameters;eslint, with the rules create-next-app enables (React Compiler hook rules, typescript-eslint recommended);prettier --check.It passes on
maintoday; I ran it locally.After this merges, consider making the type-check, lint, prettier check required in the branch rules.
🤖 Generated with Claude Code