Repository navigation
memdb: free the logs of blocks that delete from each other - #52
Merged
Merged
Conversation
A block's logs stayed in the WAL until the logs of every block it deleted versions from had gone. Blocks can delete from each other: a batch's block and the block current as it was written, or blocks that recovery of a WAL of several versions of a key links. Each waited for the other, and both kept their logs for good. A store written by v0.6.0 and compacted, 85,698 logs, kept 85,505: 11,448 blocks waited in cycles. Logs can't wait in a cycle: a delete is written after the put it deletes. A released block's logs now go with those of the blocks it deletes from, and from which they delete, once all are released, in the order they were written, so that a put's log goes before its delete's. The compacted store keeps 10 logs. A batch's block, emptied by deletes, was never released: its time ID, the batch's, can be past the current block's, and a block was released only before the current one. Written, a batch's block takes no more writes; a block is now released unless it is the current one. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
A refusal is now written as the connection closes. The client's read loop hands the CONNACK over, then the close, and connectWith's select took either: TestReleaseFourMintID saw the connection closed during connect, on master's CI. A close now takes a CONNACK waiting first. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes found while freeing a store written by v0.6.0, and one for master's CI.
selectcould take the close over the CONNACK.TestReleaseFourMintIDfailed this way on master's CI.🤖 Generated with Claude Code