Allow multiple library versions for the same ICU/CLDR version - #558
Open
sffc wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Enables running multiple versions of the same executor against the same ICU test-data version without overwriting outputs, by introducing an output_name override for output directory naming and adjusting verifier logic to map suffixed output directories back to the base ICU version for input/verify files.
Changes:
- Add
--output_nameCLI arg and wire it throughtestplan.pyoutput path construction. - Update run scripts to pass
output_namefromrun_config.jsonintotestdriver.py. - Teach the verifier to strip
@...suffixes (e.g.icu78@icu4x_2_1) when locating verify/input data.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
verifier/verifier.py |
Strips @... suffix when mapping result directory names to the base ICU version for verify/testdata lookup. |
testdriver/testplan.py |
Uses output_name (when provided) as the output directory segment to prevent overwrites. |
testdriver/ddtargs.py |
Adds --output_name argument to the common CLI args. |
run_config.json |
Adds/updates rust ICU78 entries to write to distinct output directories via output_name. |
generateDataAndRun.sh |
Passes output_name from config to testdriver.py. |
genData100.sh |
Passes output_name from config to testdriver.py (with a default when missing). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+173
to
176
| if "@" in test_version: | ||
| # Directories like "icu78@icu4x_2_1" | ||
| test_version = test_version.split("@")[0] | ||
| verify_file_path = os.path.join(self.file_base, |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
sven-oly
approved these changes
Aug 27, 2026
sven-oly
left a comment
sven-oly
left a comment
Collaborator
There was a problem hiding this comment.
This looks OK to me. It suggests that we have a better way to specify versions than just directory names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#553
Here's what it looks like:
Not completely sure if this behaves as expected, in part because there are tons and tons of errors when running the tool, which makes debugging difficult.