docs(unic-archon-dlc): record the sixth check as shipped, and what building it taught - #466
Draft
orioltf wants to merge 1 commit into
Draft
docs(unic-archon-dlc): record the sixth check as shipped, and what building it taught#466orioltf wants to merge 1 commit into
orioltf wants to merge 1 commit into
Conversation
…ilding it taught WI 43028 merged as PR 5854 (`f77ee51` on DXP-DesignSystem's `develop`), so F1's "a sixth check" row stops describing work and starts describing an artefact. F4's "five checks" becomes the F1 table, which is the count. The new F5 holds what the three `unic-dlc-pr-review` iterations produced beyond the check itself. Every row is one shape — a green that means nothing — found in four places in one day, three of them while building the instrument run 3 is read through: - a check that returned `[]` on the barrel shape `develop` gets the day the first component lands, past 12 tests including four failure fixtures; - so a positive control per check, with the technique per-check and 43020 as the counter-example that four of the six controls are still owed; - with no CI, the PR description is the only record that a check ran; - `/pr-review` iteration 3 produced eight findings, wrote none and exited 0 (#465); - four of the Consumer's eight declared commands cannot fail; - `estimations` moved `off` to `both` between the runs, retiring run 2's cost and halt figures. The last two rows are what the seal must mark not-comparable rather than score. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01THGdEfJM9zVBvMmTZPwTQk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
WI 43028 merged this morning as PR 5854 (
f77ee51onDXP-DesignSystem'sdevelop), and the run 2 findings register still described it as work to do. That row is the one #457 reads to know whether run 3's last precondition is met, so leaving it stale would leave the frontier wrong.The bigger reason is the new F5. Building the sixth check produced more than the check. Three
unic-dlc-pr-reviewiterations found twenty-three things, and the ones worth keeping are not about that check — they are about a green that means nothing, found in four places in one day, three of them inside the instrument run 3 will be read through. None of it was written down anywhere durable; it existed in one session's window and in ticket comments.What changed
One file,
docs/research/2026-08-31-dlc-run-2-findings.md.countStoriesbecame the one reader of the tag arithmetic so 43022 and 43028 cannot drift apart.[]on the barrel shapedevelopgets the day the first component lands./pr-reviewiteration 3 produced eight findings, wrote none, exited 0 — filed as bug(unic-archon-dlc): /pr-review produced eight findings, wrote none, and exited 0 #465.estimationsmovedoff→bothbetween the runs, retiring run 2's cost and halt figures.Rows 5 and 6 are what the seal marks not-comparable rather than scores.
The one judgement worth reviewing
F5 row 2 exists because I got it wrong first. My original wording on #457 generalised 43028's control technique to all six checks; 43020 breaks it, because
uiReactStyleSheets()throws on empty rather than returning[]. TheDS-43028session made the same move inside the README paragraph it added to stop over-claims. Both instances are in the row on purpose — the rule is worth more than either:If that reads as too much narrative for a findings register, say so and it compresses to the rule alone.
Verification
prettier --checkclean on the changed file (it re-padded the F1 table, which is why the diff is larger than the prose added). No package touched, no version bump, no changelog entry — this is a research document.