fix(scraper): guard against AttributeError when img has no parent in process_image#1995
Open
devteamaegis wants to merge 1 commit into
Open
fix(scraper): guard against AttributeError when img has no parent in process_image#1995devteamaegis wants to merge 1 commit into
devteamaegis wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
process_imagecallsimg.getparent()and immediately accessesparent.tagwithout checking whetherparentisNone:In lxml,
getparent()returnsNonefor detached elements — which can happen whenremove_empty_elements_fastor other tree modifications remove a parent while child<img>elements are still referenced. Any such image passed toprocess_imagewill crash:Root cause
The companion removal path at the call-site (line ~328) already guards this correctly:
But
process_imageitself — where the crash actually lives — does not.Fix
Add a
Nonecheck before accessing.tag/.get(). When the image has no parent, treatparent_classesas empty and let the image proceed to normal scoring — there is no parent context to filter on, so the safest default is to include the image.