Write current scan point to MFILE - #4611
Open
timothy-nunn wants to merge 2 commits into
Open
timothy-nunn wants to merge 2 commits into
timothy-nunn wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4611 +/- ##
=======================================
Coverage 49.97% 49.97%
=======================================
Files 151 151
Lines 29929 29917 -12
=======================================
- Hits 14956 14951 -5
+ Misses 14973 14966 -7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
je-cook
approved these changes
Sep 25, 2026
je-cook
left a comment
Collaborator
There was a problem hiding this comment.
I'm happy but @chris-ashe might have a comment about scan no 17 change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new MFILE variable that contains the current scan variable.
TODO: utilise scan variable for plotting, remove
out_nameBugfixes
nsweep_2was being written out 3 times for some reasonsv.data.descriptionwas being used instead ofsv.descriptionChanges
There is no concept of
out_nameanymore: you plot the variable you scan exactly.This changes scan variable 17
which was plotting
b_tf_inboard_peak_symmetric, but this makes no sense because it was not the scanned variable. I think this change is ok because we should not be scanning one variable and then plotting another. If that functionality is desired, people can write their own small plotting script.