Skip to content

improve-quality-job pr comment - #4609

Draft
clmould wants to merge 30 commits into
mainfrom
pr-comment-improve-quality-check-worse
Draft

clmould wants to merge 30 commits into
mainfrom
pr-comment-improve-quality-check-worse

Conversation

@clmould

@clmould clmould commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator

Description

Checklist

#4420

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@clmould
clmould marked this pull request as ready for review September 22, 2026 16:29
@clmould
clmould requested a review from a team as a code owner September 22, 2026 16:29
@clmould
clmould force-pushed the pr-comment-improve-quality-check-worse branch from 56bfbbf to e43ae70 Compare September 22, 2026 16:30
@clmould
clmould marked this pull request as draft September 22, 2026 16:30
@clmould clmould closed this Sep 22, 2026
@clmould clmould reopened this Sep 22, 2026
@clmould
clmould force-pushed the pr-comment-improve-quality-check-worse branch from d3d19f6 to 2433527 Compare September 23, 2026 09:17
@clmould
clmould force-pushed the pr-comment-improve-quality-check-worse branch from 2433527 to da60f35 Compare September 23, 2026 09:29
@codecov-commenter

codecov-commenter commented Sep 23, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 2.08333% with 47 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.89%. Comparing base (5d2d7d5) to head (55ebcce).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
process/main.py 2.08% 47 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4609      +/-   ##
==========================================
- Coverage   49.99%   49.89%   -0.10%     
==========================================
  Files         151      151              
  Lines       29916    29977      +61     
==========================================
+ Hits        14956    14957       +1     
- Misses      14960    15020      +60     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread .github/workflows/process.yml Outdated
hatch run lint:fmt_extra "${files[@]}"

env: # need number of errors being flagged in these files
num_pr_errors: $(hatch run lint:fmt_extra "${files[@]}" | wc -l)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you're doing it this way dont you just need the last line of the output and pull the number from that

Image

@clmould
clmould force-pushed the pr-comment-improve-quality-check-worse branch from a596691 to fb5f3d4 Compare September 24, 2026 14:53
@clmould
clmould force-pushed the pr-comment-improve-quality-check-worse branch from 49ee53f to d8a3a37 Compare September 24, 2026 15:29
@clmould
clmould force-pushed the pr-comment-improve-quality-check-worse branch from ad0a973 to 6bf09c1 Compare September 24, 2026 17:30
@github-actions

Copy link
Copy Markdown

Files changed by this PR have introduced $compared_errors more linting errors when compared to main.
Please fix these

@github-actions

Copy link
Copy Markdown

Files changed by this PR have introduced "$compared_errors" more linting errors when compared to main.
Please fix these

@github-actions

Copy link
Copy Markdown

Files changed by this PR have introduced more linting errors when compared to main.
Please fix these

@github-actions

Copy link
Copy Markdown

Files changed by this PR have introduced $env.compared_errors more linting errors when compared to main.
Please fix these

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants