Skip to content

Move data structure to its own file - #4555

Merged
timothy-nunn merged 3 commits into
mainfrom
data-structure-seperate-file
Aug 26, 2026
Merged

Move data structure to its own file#4555
timothy-nunn merged 3 commits into
mainfrom
data-structure-seperate-file

Conversation

@timothy-nunn

Copy link
Copy Markdown
Collaborator

This is part of the Parameterification of PROCESS however this change is very prone to causing conflicts whenever anyone changes anything. It can be moved into PROCESS main for my own sanity without the Parameter being ready yet.

@timothy-nunn
timothy-nunn requested a review from a team as a code owner August 25, 2026 16:23
@codecov-commenter

codecov-commenter commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.49%. Comparing base (986a8f0) to head (91d38f9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4555      +/-   ##
==========================================
+ Coverage   49.47%   49.49%   +0.01%     
==========================================
  Files         150      151       +1     
  Lines       30069    30076       +7     
==========================================
+ Hits        14878    14885       +7     
  Misses      15191    15191              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@je-cook je-cook left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The split out itself I agree with but is it not more appropriate for this to go into the data structure folder as eg base.py or something?

@timothy-nunn
timothy-nunn force-pushed the data-structure-seperate-file branch from a2fc7bf to 91d38f9 Compare August 26, 2026 13:52
@timothy-nunn
timothy-nunn requested a review from je-cook August 26, 2026 14:24
@timothy-nunn
timothy-nunn merged commit 26e1c28 into main Aug 26, 2026
8 of 11 checks passed
@timothy-nunn
timothy-nunn deleted the data-structure-seperate-file branch August 26, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants