Skip to content

Added variable descriptions to dataclass variables - #4554

Open
j-a-foster wants to merge 1 commit into
mainfrom
4513-missing-variable-descriptions-in-dataclasses-in-superconductingpy
Open

Added variable descriptions to dataclass variables#4554
j-a-foster wants to merge 1 commit into
mainfrom
4513-missing-variable-descriptions-in-dataclasses-in-superconductingpy

Conversation

@j-a-foster

@j-a-foster j-a-foster commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Description

Missing variable desriptions have been added to variables in superconducting.py data classes.

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@j-a-foster
j-a-foster requested a review from a team as a code owner August 25, 2026 12:34
@clmould clmould self-assigned this Aug 25, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.52%. Comparing base (a9358cc) to head (3109ed6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4554      +/-   ##
==========================================
+ Coverage   49.46%   49.52%   +0.05%     
==========================================
  Files         150      150              
  Lines       30069    30102      +33     
==========================================
+ Hits        14874    14907      +33     
  Misses      15195    15195              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mkovari

mkovari commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

These seem to be copies of the descriptions in process/data_structure/tfcoil_variables.py. Did you intend to duplicate these descriptions without deleting the originals?

@j-a-foster

Copy link
Copy Markdown
Collaborator Author

These seem to be copies of the descriptions in process/data_structure/tfcoil_variables.py. Did you intend to duplicate these descriptions without deleting the originals?

I've replicated what's been done for other dataclasses in the same file, they have descriptions which match or summarise what's in the corresponding _variables.py file. j_tf_wp_critical is one such variable that has a description in both superconducting.py and tfcoil_variables.py. Unless I'm missing something, I think they are supposed to be in both places?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing variable descriptions in dataclasses in superconducting.py

4 participants