Skip to content

Add eich profile - #4507

Open
chris-ashe wants to merge 17 commits into
mainfrom
add_eich_profile
Open

Add eich profile#4507
chris-ashe wants to merge 17 commits into
mainfrom
add_eich_profile

Conversation

@chris-ashe

@chris-ashe chris-ashe commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

This pull request introduces significant new functionality and documentation for modeling plasma scrape-off layer (SOL) physics, particularly focusing on heat flux profiles and power spreading in tokamak divertors. The main changes include the addition of new physics models and plotting functions for SOL profiles, the implementation of the Scarabosio 2014 power spreading factor, and comprehensive documentation updates to explain the new models and their physical basis.

Key changes include:

New SOL Physics Models and Methods

  • Added methods to ScrapeOffLayer for calculating the outboard midplane near-SOL radial heat flux profile (calculate_outboard_midplane_near_sol_radial_profile), the Eich target heat flux profile (calculate_eich_target_heat_flux_profile), and the Scarabosio 2014 H-mode power spreading factor (calculate_scarabosio2014_power_spreading_factor). These provide core physics calculations for SOL heat transport and divertor power spreading.
  • Updated the run method in ScrapeOffLayer to compute and store the Scarabosio 2014 and general power spreading factors in the physics data structure.
  • Added new physics variables to PhysicsData for storing the outboard lower divertor flux expansion and power spreading factors.

Plotting Enhancements

  • Introduced new plotting functions in process/core/io/plot/summary.py to visualize the midplane near-SOL radial profile, the Eich target heat flux profile at the lower outboard divertor, and a summary of SOL power fluxes. These plots leverage the new physics models and are integrated into the summary plotting workflow.
  • Registered ScrapeOffLayer in the plotting module for direct access to SOL physics calculations.
image

Documentation Improvements

  • Expanded the documentation in plasma_scrape_off_layer.md to describe the upstream radial decay, the Eich target heat flux profile, and the physical meaning of the spreading parameter S, including the Scarabosio 2015 scaling law. Added new references to support these sections.

Output and Usability

  • Enhanced the output of the ScrapeOffLayer model to include the new power spreading factors for traceability and user insight.
  • Fixed the calculation of parallel power flux by including the outboard separatrix power fraction.

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@chris-ashe chris-ashe added the Scrape off Layer Relating to the scrape off layer outside the plasma separatrix label Aug 7, 2026
@codecov-commenter

codecov-commenter commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 20.73171% with 65 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.40%. Comparing base (a9358cc) to head (9e4515f).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
process/core/io/plot/summary.py 7.01% 53 Missing ⚠️
process/models/physics/scrape_off_layer.py 36.84% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4507      +/-   ##
==========================================
- Coverage   49.46%   49.40%   -0.07%     
==========================================
  Files         150      150              
  Lines       30069    30151      +82     
==========================================
+ Hits        14874    14895      +21     
- Misses      15195    15256      +61     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…t profile plots with additional data and improved labeling
@chris-ashe
chris-ashe marked this pull request as ready for review August 26, 2026 14:36
@chris-ashe
chris-ashe requested a review from a team as a code owner August 26, 2026 14:36
@chris-ashe
chris-ashe marked this pull request as draft August 26, 2026 14:39
…h_target_profile and enhance output logging in ScrapeOffLayer model
@chris-ashe
chris-ashe marked this pull request as ready for review August 26, 2026 14:44
@chris-ashe

chris-ashe commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator Author

Can I ask someone from @ukaea/process-model-review to check if the $q_0$ term in the Eich target profile should be divided by the flux expansion factor, $f_x$. Currently the input is just the upstream $q_{\parallel,u}$

@chris-ashe
chris-ashe requested a review from a team August 26, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Divertor Scrape off Layer Relating to the scrape off layer outside the plasma separatrix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants