Add eich profile - #4507
Open
chris-ashe wants to merge 17 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4507 +/- ##
==========================================
- Coverage 49.46% 49.40% -0.07%
==========================================
Files 150 150
Lines 30069 30151 +82
==========================================
+ Hits 14874 14895 +21
- Misses 15195 15256 +61 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
chris-ashe
force-pushed
the
add_eich_profile
branch
from
August 7, 2026 16:26
d07cf8d to
ba80437
Compare
chris-ashe
force-pushed
the
add_eich_profile
branch
from
August 17, 2026 12:11
ba80437 to
87cc4bf
Compare
…ate output message
…pe off layer validation
… update calculation method
chris-ashe
force-pushed
the
add_eich_profile
branch
from
August 25, 2026 13:13
231c09b to
3075bd5
Compare
…t profile plots with additional data and improved labeling
…update scrape off layer calculations
…h factors in PhysicsData
…ma scrape-off layer documentation
…et heat flux profile
…plasma boundary visualization; update Eich target heat flux profile title and adjust label positions for clarity.
chris-ashe
marked this pull request as ready for review
August 26, 2026 14:36
chris-ashe
marked this pull request as draft
August 26, 2026 14:39
…h_target_profile and enhance output logging in ScrapeOffLayer model
chris-ashe
marked this pull request as ready for review
August 26, 2026 14:44
Collaborator
Author
|
Can I ask someone from @ukaea/process-model-review to check if the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant new functionality and documentation for modeling plasma scrape-off layer (SOL) physics, particularly focusing on heat flux profiles and power spreading in tokamak divertors. The main changes include the addition of new physics models and plotting functions for SOL profiles, the implementation of the Scarabosio 2014 power spreading factor, and comprehensive documentation updates to explain the new models and their physical basis.
Key changes include:
New SOL Physics Models and Methods
ScrapeOffLayerfor calculating the outboard midplane near-SOL radial heat flux profile (calculate_outboard_midplane_near_sol_radial_profile), the Eich target heat flux profile (calculate_eich_target_heat_flux_profile), and the Scarabosio 2014 H-mode power spreading factor (calculate_scarabosio2014_power_spreading_factor). These provide core physics calculations for SOL heat transport and divertor power spreading.runmethod inScrapeOffLayerto compute and store the Scarabosio 2014 and general power spreading factors in the physics data structure.PhysicsDatafor storing the outboard lower divertor flux expansion and power spreading factors.Plotting Enhancements
process/core/io/plot/summary.pyto visualize the midplane near-SOL radial profile, the Eich target heat flux profile at the lower outboard divertor, and a summary of SOL power fluxes. These plots leverage the new physics models and are integrated into the summary plotting workflow.ScrapeOffLayerin the plotting module for direct access to SOL physics calculations.Documentation Improvements
plasma_scrape_off_layer.mdto describe the upstream radial decay, the Eich target heat flux profile, and the physical meaning of the spreading parameter S, including the Scarabosio 2015 scaling law. Added new references to support these sections.Output and Usability
ScrapeOffLayermodel to include the new power spreading factors for traceability and user insight.Checklist
I confirm that I have completed the following checks: